Add transaction message support #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
reviewed
Oct 14, 2019
|
|
||
| void *PyCreateTransactionProducer(const char *groupId, PyObject *localTransactionCheckerCallback) { | ||
| PyEval_InitThreads(); | ||
| CProducer *producer = CreateTransactionProducer(groupId, &PyLocalTransactionCheckerCallback, NULL); |
There was a problem hiding this comment.
I can't find CreateTransactionProducer implementation in the cpp repository, only the function prototype was found.
messense
reviewed
Oct 14, 2019
| PySendResult ret; | ||
| CSendResult result; | ||
| SendMessageOrderlyByShardingKey((CProducer *) producer, (CMessage *) msg, shardingKey, &result); | ||
| SendMessageTransaction((CProducer *) producer, (CMessage *) msg, &PyLocalTransactionExecuteCallback, &userData, |
There was a problem hiding this comment.
Can't find SendMessageTransaction function, not even function prototype.
There was a problem hiding this comment.
Relative c exporter hasn't released and it will be published ASAP, you can ignore this for now.
* 'master' of github.com:apache/rocketmq-client-python: feat(travis) upgrade cpp core from 1.2.0 to 1.2.0
ShannonDing
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add transaction message support
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.