Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][build] Remove the connector-*dist module #2673

Closed
3 tasks done
ashulin opened this issue Sep 7, 2022 · 0 comments · Fixed by #2702, #2703 or #2709
Closed
3 tasks done

[Improve][build] Remove the connector-*dist module #2673

ashulin opened this issue Sep 7, 2022 · 0 comments · Fixed by #2702, #2703 or #2709
Assignees

Comments

@ashulin
Copy link
Member

ashulin commented Sep 7, 2022

Search before asking

  • I had searched in the feature and found no similar feature requirement.

Motivation

  1. Reduce the size of the packaged seatunnel;

Backgroud

I found that the dist module of the connector can be removed, and it is currently used in two scenarios:

  1. [Improve][e2e] container only copy required connector jars #2681 Copy the connector dependencies to the container during the e2e test: this will copy all the connectors of the entire dist, which is unnecessary. I am going to use plugin.mapping and conf parsing to only copy the required connectors: ;
  2. Use the maven plugin to copy all connectors to a specific folder when releasing: this is necessary, but it can be achieved in other ways; I am going to divide the dependencies of dist into multiple profiles and migrate them to seatunnel-dist ;

Usage Scenario

  1. maven build

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ashulin ashulin self-assigned this Sep 7, 2022
@ashulin ashulin changed the title [Improve] Remove the connector-*dist module & Improved dependencies for e2e [Improve][build] Remove the connector-*dist module Sep 8, 2022
@ashulin ashulin linked a pull request Sep 9, 2022 that will close this issue
3 tasks
@ashulin ashulin linked a pull request Sep 9, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment