[Bug] [PHP] broken build with OPENSSL_NO_ENGINE

[remicollet]

Search before asking

• I had searched in the issues and found no similar issues.

Apache SkyWalking Component

PHP (apache/skywalking-php)

What happened

Build fails on RHEL-10-beta where OpenSSL is built with OPENSSL_NO_ENGINE

rdkafka-sys bundles old librdkafka 1.9

  rdkafka_ssl.c:1337:24: error: implicit declaration of function ‘ENGINE_load_ssl_client_cert’ [-Wimplicit-function-declaration]
   1337 |                 r    = ENGINE_load_ssl_client_cert(
        |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
  In file included from rdkafka_int.h:46,
                   from rdkafka_ssl.c:35:
  rdkafka_ssl.c: In function ‘rd_kafka_ssl_ctx_term’:
  rdkafka_ssl.c:1407:44: error: implicit declaration of function ‘ENGINE_free’ [-Wimplicit-function-declaration]
   1407 |         RD_IF_FREE(rk->rk_conf.ssl.engine, ENGINE_free);
        |                                            ^~~~~~~~~~~
  rd.h:415:25: note: in definition of macro ‘RD_IF_FREE’
    415 |                         FUNC(PTR);                                             \
        |                         ^~~~
  rdkafka_ssl.c: In function ‘rd_kafka_ssl_ctx_init_engine’:
  rdkafka_ssl.c:1427:18: error: implicit declaration of function ‘ENGINE_by_id’ [-Wimplicit-function-declaration]
   1427 |         engine = ENGINE_by_id(rk->rk_conf.ssl.engine_id);
        |                  ^~~~~~~~~~~~
  rdkafka_ssl.c:1427:16: error: assignment to ‘ENGINE *’ {aka ‘struct engine_st *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
   1427 |         engine = ENGINE_by_id(rk->rk_conf.ssl.engine_id);
        |                ^
  rdkafka_ssl.c:1429:24: error: assignment to ‘ENGINE *’ {aka ‘struct engine_st *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
   1429 |                 engine = ENGINE_by_id("dynamic");
        |                        ^
  rdkafka_ssl.c:1438:14: error: implicit declaration of function ‘ENGINE_ctrl_cmd_string’ [-Wimplicit-function-declaration]
   1438 |         if (!ENGINE_ctrl_cmd_string(engine, "SO_PATH",
        |              ^~~~~~~~~~~~~~~~~~~~~~
  rdkafka_ssl.c:1463:14: error: implicit declaration of function ‘ENGINE_init’ [-Wimplicit-function-declaration]
   1463 |         if (!ENGINE_init(engine)) {
        |              ^~~~~~~~~~~

Upcoming version 2.6.2 should be compatible
See confluentinc/librdkafka#3535

What you expected to happen

success

How to reproduce

Build on any distribution using OPENSSL_NO_ENGINE

Anything else

No response

Are you willing to submit a pull request to fix on your own?

• Yes I am willing to submit a pull request on my own!

Code of Conduct

• I agree to follow this project's Code of Conduct

[jmjoy]

Maybe we can change the rdkafka dependency to dynamic-linking.

[jmjoy]

rust-rdkafka has high requirements for the rdkafka version (1.9.2). If dynamic linking is used, the version in the source of the distribution is not easy to meet. Let's wait for the release of rdkafka 2.6.2.