[SPARK-49749][CORE] Change log level to debug in BlockManagerInfo #48197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyum
changed the title
MaxGekk
approved these changes
Sep 22, 2024
yaooqinn
approved these changes
Sep 22, 2024
pan3793
reviewed
Sep 22, 2024
| @@ -1059,13 +1059,13 @@ private[spark] class BlockManagerInfo( | |||
| _blocks.put(blockId, blockStatus) | |||
| _remainingMem -= memSize | |||
| if (blockExists) { | |||
| logInfo(log"Updated ${MDC(BLOCK_ID, blockId)} in memory on " + | |||
| logDebug(log"Updated ${MDC(BLOCK_ID, blockId)} in memory on " + | |||
There was a problem hiding this comment.
structured logging is only supposed to be used for logInfo/logWarning/logError, please also change the value to String
dongjoon-hyun
requested changes
Sep 22, 2024
There was a problem hiding this comment.
I also agree with the above @MaxGekk 's comment. We need a result of after this PR for the below claim, @wangyum . The comparison between BEFORE and AFTER is mandatory for this kind of claim.
Logging in BlockManagerMasterEndpoint uses 3.25% of the CPU and generates 60.5% of the logs.
Otherwise, please remove the claim. We can say simply that this too verbose in a tone-downed manner.
|
I have updated the number after this change. |
beliefer
approved these changes
Sep 27, 2024
dongjoon-hyun
approved these changes
Sep 29, 2024
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? This PR changes the log level to debug in `BlockManagerInfo`. ### Why are the changes needed? Before this PR: Logging in `BlockManagerMasterEndpoint` uses 3.25% of the CPU and generates 60.5% of the logs. <img width="1186" alt="image" src="https://github.com/user-attachments/assets/81013d98-8700-4e4f-a1aa-aa17fc0c5c52"> ``` cat spark.20240921-09.log | grep "in memory on" | wc -l 8587851 cat spark.20240921-09.log | wc -l 14185544 ``` After this PR: <img width="1196" alt="image" src="https://github.com/user-attachments/assets/6d52cd2c-de3b-4a32-a6e8-a98c42909faa"> ``` cat spark.20240926-09.log | grep "in memory on" | wc -l 0 cat spark.20240926-09.log | wc -l 2224037 ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48197 from wangyum/SPARK-49749. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? This PR changes the log level to debug in `BlockManagerInfo`. ### Why are the changes needed? Before this PR: Logging in `BlockManagerMasterEndpoint` uses 3.25% of the CPU and generates 60.5% of the logs. <img width="1186" alt="image" src="https://github.com/user-attachments/assets/81013d98-8700-4e4f-a1aa-aa17fc0c5c52"> ``` cat spark.20240921-09.log | grep "in memory on" | wc -l 8587851 cat spark.20240921-09.log | wc -l 14185544 ``` After this PR: <img width="1196" alt="image" src="https://github.com/user-attachments/assets/6d52cd2c-de3b-4a32-a6e8-a98c42909faa"> ``` cat spark.20240926-09.log | grep "in memory on" | wc -l 0 cat spark.20240926-09.log | wc -l 2224037 ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48197 from wangyum/SPARK-49749. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR changes the log level to debug in
BlockManagerInfo.Why are the changes needed?
Before this PR:
Logging in
BlockManagerMasterEndpointuses 3.25% of the CPU and generates 60.5% of the logs.After this PR:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A.
Was this patch authored or co-authored using generative AI tooling?
No.