{isApplied && (
-
+
)}
{onDelete && (
= ({
buttonStyle="link"
buttonSize="xsmall"
>
-
+
)}
diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.test.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.test.tsx
index a54d7cbac5daa..8074525f4e5b5 100644
--- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.test.tsx
+++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.test.tsx
@@ -30,12 +30,13 @@ import { DndMetricSelect } from 'src/explore/components/controls/DndColumnSelect
import { AGGREGATES } from 'src/explore/constants';
import { EXPRESSION_TYPES } from '../MetricControl/AdhocMetric';
-jest.mock(
- 'src/components/Icons/Icon',
- () =>
- ({ fileName }: { fileName: string }) =>
- ,
-);
+jest.mock('src/components/Icons/Icon', () => ({
+ __esModule: true,
+ default: ({ fileName }: { fileName: string }) => (
+
+ ),
+ StyledIcon: () => ,
+}));
const defaultProps = {
savedMetrics: [
diff --git a/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx b/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
index fa794e871ce57..62fcdaaf15ac9 100644
--- a/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
+++ b/superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
@@ -18,8 +18,8 @@
*/
import React, { useCallback, useMemo, useState } from 'react';
import { useSelector } from 'react-redux';
-import { FileOutlined, FileImageOutlined } from '@ant-design/icons';
import { css, styled, t, useTheme } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
import { Menu } from 'src/components/Menu';
import ModalTrigger from 'src/components/ModalTrigger';
import Button from 'src/components/Button';
@@ -92,6 +92,13 @@ export const MenuTrigger = styled(Button)`
`}
`;
+const iconReset = css`
+ .ant-dropdown-menu-item > & > .anticon:first-child {
+ margin-right: 0;
+ vertical-align: 0;
+ }
+`;
+
export const useExploreAdditionalActionsMenu = (
latestQueryFormData,
canDownloadCSV,
@@ -271,14 +278,14 @@ export const useExploreAdditionalActionsMenu = (
<>
}
+ icon={}
disabled={!canDownloadCSV}
>
{t('Export to original .CSV')}
}
+ icon={}
disabled={!canDownloadCSV}
>
{t('Export to pivoted .CSV')}
@@ -287,18 +294,21 @@ export const useExploreAdditionalActionsMenu = (
) : (
}
+ icon={}
disabled={!canDownloadCSV}
>
{t('Export to .CSV')}
)}
- }>
+ }
+ >
{t('Export to .JSON')}
}
+ icon={}
>
{t('Download as image')}
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/EncryptedField.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/EncryptedField.tsx
index 5870345b444fe..4959ddb882fa8 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/EncryptedField.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/EncryptedField.tsx
@@ -21,7 +21,7 @@ import { SupersetTheme, t } from '@superset-ui/core';
import { AntdButton, AntdSelect } from 'src/components';
import InfoTooltip from 'src/components/InfoTooltip';
import FormLabel from 'src/components/Form/FormLabel';
-import { DeleteFilled } from '@ant-design/icons';
+import Icons from 'src/components/Icons';
import { FieldPropTypes } from '.';
import { infoTooltip, labelMarginBotton, CredentialInfoForm } from '../styles';
@@ -152,7 +152,8 @@ export const EncryptedField = ({
{fileToUpload && (
{fileToUpload}
- {
setFileToUpload(null);
changeMethods.onParametersChange({
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/TableCatalog.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/TableCatalog.tsx
index fb70b9c3652a1..ed5cc94903f2b 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/TableCatalog.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/TableCatalog.tsx
@@ -17,10 +17,10 @@
* under the License.
*/
import React from 'react';
-import { t } from '@superset-ui/core';
+import { css, SupersetTheme, t } from '@superset-ui/core';
import ValidatedInput from 'src/components/Form/LabeledErrorBoundInput';
import FormLabel from 'src/components/Form/FormLabel';
-import { CloseOutlined } from '@ant-design/icons';
+import Icons from 'src/components/Icons';
import { FieldPropTypes } from '.';
import { StyledFooterButton, StyledCatalogTable } from '../styles';
import { CatalogObject } from '../../types';
@@ -64,8 +64,17 @@ export const TableCatalog = ({
value={sheet.name}
/>
{tableCatalog?.length > 1 && (
- css`
+ align-self: center;
+ background: ${theme.colors.grayscale.light4};
+ margin: 5px 5px 8px 5px;
+
+ &.anticon > * {
+ line-height: 0;
+ }
+ `}
+ iconSize="m"
onClick={() => changeMethods.onRemoveTableCatalog(idx)}
/>
)}
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts
index 31b3f84031baf..048f15ee03da5 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts
@@ -605,12 +605,6 @@ export const StyledCatalogTable = styled.div`
width: 95%;
}
- .catalog-delete {
- align-self: center;
- background: ${({ theme }) => theme.colors.grayscale.light4};
- margin: 5px 5px 8px 5px;
- }
-
.catalog-add-btn {
width: 95%;
}
diff --git a/superset/common/query_context_processor.py b/superset/common/query_context_processor.py
index 17cc5fd4119d9..e6fa964e4d7bd 100644
--- a/superset/common/query_context_processor.py
+++ b/superset/common/query_context_processor.py
@@ -576,6 +576,7 @@ def get_viz_annotation_data(
if not chart.datasource:
raise QueryObjectValidationError(_("The chart datasource does not exist"))
form_data = chart.form_data.copy()
+ form_data.update(annotation_layer.get("overrides", {}))
try:
viz_obj = get_viz(
datasource_type=chart.datasource.type,