From 7c2bf4da285cdc3de09a55536fdbdb001612236a Mon Sep 17 00:00:00 2001 From: Simcha Shats Date: Thu, 11 Feb 2021 14:47:22 +0200 Subject: [PATCH] refactor: fix cr notes --- .../spec/javascripts/dashboard/util/getDashboardUrl_spec.js | 2 +- .../javascripts/explore/components/EmbedCodeButton_spec.jsx | 2 +- superset-frontend/spec/javascripts/explore/utils_spec.jsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset-frontend/spec/javascripts/dashboard/util/getDashboardUrl_spec.js b/superset-frontend/spec/javascripts/dashboard/util/getDashboardUrl_spec.js index 39b821124d20a..77a19c7717246 100644 --- a/superset-frontend/spec/javascripts/dashboard/util/getDashboardUrl_spec.js +++ b/superset-frontend/spec/javascripts/dashboard/util/getDashboardUrl_spec.js @@ -59,7 +59,7 @@ describe('getChartIdsFromLayout', () => { ); }); - it('should encode filters with missed standalone', () => { + it('should encode filters with missing standalone', () => { const urlWithStandalone = getDashboardUrl('path', filters, '', null); expect(urlWithStandalone).toBe( 'path?preselect_filters=%7B%2235%22%3A%7B%22key%22%3A%5B%22value%22%5D%7D%7D', diff --git a/superset-frontend/spec/javascripts/explore/components/EmbedCodeButton_spec.jsx b/superset-frontend/spec/javascripts/explore/components/EmbedCodeButton_spec.jsx index 7b52b6d7bf04b..74c0d21e38cda 100644 --- a/superset-frontend/spec/javascripts/explore/components/EmbedCodeButton_spec.jsx +++ b/superset-frontend/spec/javascripts/explore/components/EmbedCodeButton_spec.jsx @@ -27,7 +27,7 @@ import fetchMock from 'fetch-mock'; import EmbedCodeButton from 'src/explore/components/EmbedCodeButton'; import * as exploreUtils from 'src/explore/exploreUtils'; import * as urlUtils from 'src/utils/urlUtils'; -import { DashboardStandaloneMode } from '../../../../src/dashboard/util/constants'; +import { DashboardStandaloneMode } from 'src/dashboard/util/constants'; const ENDPOINT = 'glob:*/r/shortner/'; diff --git a/superset-frontend/spec/javascripts/explore/utils_spec.jsx b/superset-frontend/spec/javascripts/explore/utils_spec.jsx index 30a9641496d96..d416fc05ff0b3 100644 --- a/superset-frontend/spec/javascripts/explore/utils_spec.jsx +++ b/superset-frontend/spec/javascripts/explore/utils_spec.jsx @@ -30,9 +30,9 @@ import { buildTimeRangeString, formatTimeRange, } from 'src/explore/dateFilterUtils'; +import { DashboardStandaloneMode } from 'src/dashboard/util/constants'; import * as hostNamesConfig from 'src/utils/hostNamesConfig'; import { getChartMetadataRegistry } from '@superset-ui/core'; -import { DashboardStandaloneMode } from '../../../src/dashboard/util/constants'; describe('exploreUtils', () => { const { location } = window;