Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change status colors for running vs successful query in sqllab #11123

Closed
cooley-pe opened this issue Sep 30, 2020 · 6 comments
Closed

Change status colors for running vs successful query in sqllab #11123

cooley-pe opened this issue Sep 30, 2020 · 6 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community good first issue Good first issues for new contributors need:followup Requires followup sqllab:control:ui

Comments

@cooley-pe
Copy link

Is your feature request related to a problem? Please describe.
I have a lot of trouble distinguishing between the shades of green signifying a running vs successful query in sqllab.

Describe the solution you'd like
Ideally these would be two different colors for running vs successful. Maybe yellow and green respectively?

Describe alternatives you've considered
If there isn't an entirely different color that makes sense, making the greens more distinct would be helpful.

Additional context
Success on the left and running on the right:
Screen Shot 2020-09-30 at 3 40 02 PM

@cooley-pe cooley-pe added the enhancement:request Enhancement request submitted by anyone from the community label Sep 30, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@junlincc junlincc added the good first issue Good first issues for new contributors label Oct 1, 2020
@sahilkamboj3
Copy link

Hey @junlincc , I'd like to contribute. Is the issue available to work on?

@junlincc
Copy link
Member

@sahilkamboj3 Hi! sorry I missed your comment 🙏 proposed solution sounds reasonable. Please go ahead and open a PR, we will review for sure.

cc @Steejay

@junlincc junlincc added the need:followup Requires followup label Feb 16, 2021
@Steejay
Copy link

Steejay commented Feb 16, 2021

Thanks for raising this issue @cooley-pe!

@sahilkamboj3 Solution sounds good but lmk if/when you need further design input

@yousoph
Copy link
Member

yousoph commented Mar 17, 2021

A suggestion on #13648 was to have a hollow green o for the running icon and a filled in o for the successful query.

@jamesfurnary
Copy link

Hi @Steejay and @sahilkamboj3, do you have an update on this? CC @cooley-pe

Thanks,
James

@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18402 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement:request Enhancement request submitted by anyone from the community good first issue Good first issues for new contributors need:followup Requires followup sqllab:control:ui
Projects
None yet
Development

No branches or pull requests

7 participants