Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explore] adhoc filter SAVED METRIC display #12363

Closed
graceguo-supercat opened this issue Jan 8, 2021 · 6 comments · Fixed by #12387
Closed

[Explore] adhoc filter SAVED METRIC display #12363

graceguo-supercat opened this issue Jan 8, 2021 · 6 comments · Fixed by #12387
Labels
assigned:preset Assigned to the Preset team #bug:cosmetic Cosmetic/layout/design tweak needed explore:control Related to the controls panel of Explore explore:filter Related to filters in Explore P2 Priority item - High

Comments

@graceguo-supercat
Copy link

graceguo-supercat commented Jan 8, 2021 •
edited
Loading

  1. dropdown list:

Screen Shot 2021-01-08 at 1 28 13 PM

  1. ad-hoc filter:

Screen Shot 2021-01-08 at 1 42 39 PM

screenshot explains. We have many saved metric that have long name. cc @junlincc @zuzana-vej @ktmud
@graceguo-supercat graceguo-supercat added P1 Priority item - Major explore:control Related to the controls panel of Explore explore:filter Related to filters in Explore #bug Bug report labels Jan 8, 2021
@graceguo-supercat graceguo-supercat changed the title [Explore] adhoc filter SAVED METRIC name [Explore] adhoc filter SAVED METRIC in the dropdown list Jan 8, 2021
@junlincc
Copy link
Member

junlincc commented Jan 8, 2021

i tested master this morning and it was working normally. when did you see it happen? @graceguo-supercat

@junlincc junlincc removed #bug Bug report explore:control Related to the controls panel of Explore labels Jan 8, 2021
@graceguo-supercat graceguo-supercat changed the title [Explore] adhoc filter SAVED METRIC in the dropdown list [Explore] adhoc filter SAVED METRIC display Jan 8, 2021
@graceguo-supercat
Copy link
Author

i tested master this morning and it was working normally. when did you see it happen? @graceguo-supercat

Could you try master branch sha 7c8ead8

@junlincc
Copy link
Member

junlincc commented Jan 9, 2021

Will do!

just wanna confirm it works properly on master
Screen Shot 2021-01-08 at 6 07 59 PM

@junlincc junlincc added #bug:cant-reproduce Bugs that cannot be reproduced validation:required A committer should validate the issue labels Jan 9, 2021
@graceguo-supercat
Copy link
Author

could you create some long metric name? short metrics also works for me:

Screen Shot 2021-01-08 at 11 02 15 PM

@junlincc junlincc removed the P1 Priority item - Major label Jan 9, 2021
@junlincc
Copy link
Member

junlincc commented Jan 9, 2021 •
edited
Loading

Screen Shot 2021-01-09 at 1 46 21 AM

yup, it's another long title not able to display issue 😔 on it

@junlincc junlincc added explore:control Related to the controls panel of Explore #bug:cosmetic Cosmetic/layout/design tweak needed P2 Priority item - High and removed #bug:cant-reproduce Bugs that cannot be reproduced validation:required A committer should validate the issue labels Jan 9, 2021
@junlincc
Copy link
Member

junlincc commented Jan 9, 2021

Screen Shot 2021-01-09 at 2 10 43 AM

old behavior did allow longer metrics display but also had over flow issue

@zhaoyongjie zhaoyongjie mentioned this issue Jan 9, 2021
Merged
6 tasks
@junlincc junlincc added the assigned:preset Assigned to the Preset team label Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned:preset Assigned to the Preset team #bug:cosmetic Cosmetic/layout/design tweak needed explore:control Related to the controls panel of Explore explore:filter Related to filters in Explore P2 Priority item - High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(explore): long metric name display zhaoyongjie/incubator-superset
2 participants
@graceguo-supercat @junlincc