Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sample]The new "FCC 2018 Survey" data has bad calculated column #12559

Closed
3 tasks done
ktmud opened this issue Jan 15, 2021 · 3 comments
Closed
3 tasks done

[sample]The new "FCC 2018 Survey" data has bad calculated column #12559

ktmud opened this issue Jan 15, 2021 · 3 comments
Assignees
Labels
!deprecated-label:bug Deprecated label - Use #bug instead doc:examples Related to example datasets and dashboards

Comments

@ktmud
Copy link
Member

ktmud commented Jan 15, 2021

Screenshots

If you "View Samples" or select the "Highest Degree Earned" column in a table chart, you will see follow error:

Snip20210115_170

image

This is because the column expression used double quotes which will be considered column name escaping in most databases:

image

How to reproduce the bug

  1. Choose "FCC 2018 Survey" dataset
  2. Go to "View Samples" or use the "Highest Degree Earned" column anywhere in a chart

Environment

Latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@ktmud ktmud added the #bug Bug report label Jan 15, 2021
@ktmud ktmud added the doc:examples Related to example datasets and dashboards label Jan 15, 2021
@ktmud ktmud closed this as completed Jan 15, 2021
@betodealmeida
Copy link
Member

@ktmud was this closed on purpose?

@ktmud ktmud reopened this Jan 15, 2021
@ktmud
Copy link
Member Author

ktmud commented Jan 15, 2021

@betodealmeida oh no... didn't know how I clicked on close..

@betodealmeida
Copy link
Member

Cool, let me fix this.

@junlincc junlincc changed the title The new "FCC 2018 Survey" data has bad calculated column [sample]The new "FCC 2018 Survey" data has bad calculated column Jan 15, 2021
@zuzana-vej zuzana-vej added !deprecated-label:bug Deprecated label - Use #bug instead and removed #bug Bug report labels Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead doc:examples Related to example datasets and dashboards
Projects
None yet
Development

No branches or pull requests

3 participants