Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share button should also be controlled via roles #13774

Closed
saurabnigam opened this issue Mar 24, 2021 · 3 comments
Closed

Share button should also be controlled via roles #13774

saurabnigam opened this issue Mar 24, 2021 · 3 comments
Labels
authentication:RBAC Related to RBAC enhancement:request Enhancement request submitted by anyone from the community

Comments

@saurabnigam
Copy link

Is your feature request related to a problem? Please describe.
Share button such as dashboard or share chart should be optional

Describe the solution you'd like
A role for showing the share button would be sufficient

Describe alternatives you've considered
Adding CSS class specific for share button so custom CSS could be written to remove the element if not required

Additional context
We made a dashboard and want to share it externally. Problem is that there is a share button in charts as well which is not required and there is no way of removing it

@junlincc junlincc added authentication:RBAC Related to RBAC enhancement:request Enhancement request submitted by anyone from the community labels Mar 26, 2021
@junlincc
Copy link
Member

some efforts have been made towards this goal.
[SIP-51] Dashboard Level Access
#13108

cc @amitmiran137

@amitmiran137
Copy link
Member

All other option on chart menu(explore /export and etc') are controlled via a permission that been been given to a role.

I think that share chart should also behave the same in the form of ' share chart permission that can be linked to any role.

Wdyt?

@amitmiran137
Copy link
Member

@saurabnigam if you'll create a PR with the new permission for share chart I'll support you

@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18468 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
authentication:RBAC Related to RBAC enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Development

No branches or pull requests

3 participants