Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explore] Explore column icon got lost in icon color change #14697

Closed
junlincc opened this issue May 18, 2021 · 2 comments · Fixed by #14717
Closed

[Explore] Explore column icon got lost in icon color change #14697

junlincc opened this issue May 18, 2021 · 2 comments · Fixed by #14717
Assignees
@geido
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed

Comments

@junlincc
Copy link
Member

junlincc commented May 18, 2021 •
edited
Loading

Current Behavior
Screen Shot 2021-05-17 at 3 18 17 PM

Expected Behavior
Screen Shot 2021-05-18 at 1 38 50 PM

Screen Shot 2021-05-18 at 1 38 54 PM
@junlincc junlincc added bash! #bug:cosmetic Cosmetic/layout/design tweak needed labels May 18, 2021
@pkdotson pkdotson self-assigned this May 18, 2021
@geido
Copy link
Member

geido commented May 19, 2021 •
edited
Loading

@junlincc would you mind changing the title as this is not related to the icon migration, as I reported in the issue #14679. This is instead related to the PR #14674 where the width of the icons was changed. I am already working on a fix as you requested.

@pkdotson would you mind dropping this to me? Thanks

@junlincc junlincc changed the title [Explore] Explore column icon got lost in recent icon migration [Explore] Explore column icon got lost in icon color change May 19, 2021
@junlincc junlincc assigned geido and unassigned pkdotson May 19, 2021
@junlincc
Copy link
Member Author

@geido thanks for the details. feel free to pick up the ticket.

@geido geido mentioned this issue May 19, 2021
Merged
8 tasks
@rusackas rusackas mentioned this issue May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geido geido

Labels
#bug:cosmetic Cosmetic/layout/design tweak needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(explore): Icons width
3 participants
@pkdotson @geido @junlincc