Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native-filters]"No filter" state in wrong section of filter indicator #15027

Closed
junlincc opened this issue Jun 7, 2021 · 0 comments · Fixed by #15015
Closed

[native-filters]"No filter" state in wrong section of filter indicator #15027

junlincc opened this issue Jun 7, 2021 · 0 comments · Fixed by #15015
Assignees
@villebro
Labels
#bug Bug report dashboard:indicator Related to the filter indicator of a Dashboard dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major test:case

Comments

@junlincc
Copy link
Member

junlincc commented Jun 7, 2021

Expected behavior: when user select "No filter" in time range filter, it should send it to Unset filter section in the indicator.

Screen Shot 2021-06-07 at 1 37 34 PM
@junlincc junlincc added dashboard:native-filters Related to the native filters of the Dashboard dashboard:indicator Related to the filter indicator of a Dashboard #bug Bug report labels Jun 7, 2021
@junlincc junlincc added P1 Priority item - Major test:case labels Jun 7, 2021
@villebro villebro mentioned this issue Jun 8, 2021
Merged
8 tasks
@villebro villebro self-assigned this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@villebro villebro

Labels
#bug Bug report dashboard:indicator Related to the filter indicator of a Dashboard dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major test:case
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(native-filters): remove hard-coded default time range preset-io/superset
2 participants
@villebro @junlincc