Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache key for warm_up_cache and explore_json are not matching #15497

Closed
2 of 3 tasks
ukm21 opened this issue Jul 1, 2021 · 2 comments · Fixed by #23012
Closed
2 of 3 tasks

cache key for warm_up_cache and explore_json are not matching #15497

ukm21 opened this issue Jul 1, 2021 · 2 comments · Fixed by #23012
Labels
#bug Bug report inactive Inactive for >= 30 days

Comments

@ukm21
Copy link

ukm21 commented Jul 1, 2021

Both the /warm_up_cache/ and /explore_json/ API endpoints should produce the same cache key for a given slice

Expected results

should return same cache key

Actual results

different cache key are getting generated

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

  1. run cache warmup for a slice
  2. check the cache key value
  3. explore the same slice in browser
  4. different cache key will be generated so query will be fired.

Environment

(please complete the following information):

  • superset version: 1.1.0
  • python version: 3.8.9
  • node.js version: 12

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Json_Data for Explore chart

{"changed_on":1621922272000.0,"columns":["app_name"],"datasource":"1__table","extra_cache_keys":[],"extras":{"having":"","having_druid":[],"time_grain_sqla":"P1D","time_range_endpoints":["inclusive","exclusive"]},"filter":[],"granularity":null,"groupby":[],"is_rowcount":false,"is_timeseries":false,"metrics":[{"aggregate":"COUNT_DISTINCT","column":{"column_name":"app_id","description":null,"expression":null,"filterable":true,"groupby":true,"id":5,"is_dttm":false,"python_date_format":null,"type":"STRING","verbose_name":null},"expressionType":"SIMPLE","hasCustomLabel":false,"isNew":false,"label":"COUNT_DISTINCT(app_id)","optionName":"metric_6qp914zxuux_o2r0useg7ob","sqlExpression":null}],"order_desc":true,"orderby":[[{"aggregate":"COUNT_DISTINCT","column":{"column_name":"app_id","description":null,"expression":null,"filterable":true,"groupby":true,"id":5,"is_dttm":false,"python_date_format":null,"type":"STRING","verbose_name":null},"expressionType":"SIMPLE","hasCustomLabel":false,"isNew":false,"label":"COUNT_DISTINCT(app_id)","optionName":"metric_6qp914zxuux_o2r0useg7ob","sqlExpression":null},false]],"rls":[],"row_limit":100,"row_offset":0,"time_range":"Last week","timeseries_limit":0,"timeseries_limit_metric":null}

Json Data for warmup

{"changed_on":"2021-05-25T05:57:52","datasource":"1__table","extra_cache_keys":[],"extras":{"druid_time_origin":"","having":"","having_druid":[],"time_grain_sqla":"P1D","time_range_endpoints":["inclusive","exclusive"],"where":""},"filter":[],"granularity":null,"groupby":["app_name"],"is_timeseries":false,"metrics":[{"aggregate":"COUNT_DISTINCT","column":{"column_name":"app_id","description":null,"expression":null,"filterable":true,"groupby":true,"id":5,"is_dttm":false,"python_date_format":null,"type":"STRING","verbose_name":null},"expressionType":"SIMPLE","hasCustomLabel":false,"isNew":false,"label":"COUNT_DISTINCT(app_id)","optionName":"metric_6qp914zxuux_o2r0useg7ob","sqlExpression":null}],"order_desc":true,"orderby":[[{"aggregate":"COUNT_DISTINCT","column":{"column_name":"app_id","description":null,"expression":null,"filterable":true,"groupby":true,"id":5,"is_dttm":false,"python_date_format":null,"type":"STRING","verbose_name":null},"expressionType":"SIMPLE","hasCustomLabel":false,"isNew":false,"label":"COUNT_DISTINCT(app_id)","optionName":"metric_6qp914zxuux_o2r0useg7ob","sqlExpression":null},false]],"rls":[],"row_limit":100,"time_range":"Last week","timeseries_limit":0,"timeseries_limit_metric":null}

@ukm21 ukm21 added the #bug Bug report label Jul 1, 2021
@low-on-mana
Copy link

Facing the same issue, I hit warm_up_cache endpoint and it generates new key in redis.
Also, the celery job hits explore endpoint to warm_up_cache which is non functional as well.

@ukm21 were you able to solve this ?

@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report inactive Inactive for >= 30 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants