Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent filter is persisting after canceling #17144

Closed
3 tasks done
michael-s-molina opened this issue Oct 18, 2021 · 2 comments
Closed
3 tasks done

Parent filter is persisting after canceling #17144

michael-s-molina opened this issue Oct 18, 2021 · 2 comments
Labels
#bug Bug report

Comments

@michael-s-molina
Copy link
Member

michael-s-molina commented Oct 18, 2021

In native filters, the parent filter is persisting after canceling.

@m-ajay @graceguo-supercat @jinghua-qa

How to reproduce the bug

  1. Go to the native filters configuration modal
  2. Set a parent filter
  3. Cancel the changes
  4. Reopen the modal
  5. The parent filter is still there

Expected results

The parent filter is not there anymore after canceling.

Actual results

The parent filter persists after canceling.

Screenshots

Screen.Recording.2021-10-18.at.10.31.20.AM.mov

Environment

  • browser type and version: Chrome 94.0.4606.81
  • superset version: master
  • any feature flags active: NATIVE_FILTERS

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@graceguo-supercat
Copy link

thanks for record the issue!

@etr2460
Copy link
Member

etr2460 commented Oct 27, 2021

Fixed by #17217

@etr2460 etr2460 closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

3 participants