Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'typing' is circular with 'jinja2''s typing,maybe rename the typing #18019

Closed
FireJohnny opened this issue Jan 13, 2022 · 1 comment
Closed

Comments

@FireJohnny
Copy link

Please make sure you are familiar with the SIP process documented
(here)[https://github.com//issues/5602]. The SIP number should be the next number after the latest SIP listed here.

[SIP-<number>] Proposal for <title>

Motivation

Description of the problem to be solved.

ImportError: cannot import name 'Any' from partially initialized module 'typing' (most likely due to a circular import)
That typing is in superset and another typing form jinja2\bccache.py

Proposed Change

Describe how the feature will be implemented, or the problem will be solved. If possible, include mocks, screenshots, or screencasts (even if from different tools).
change typing name.

New or Changed Public Interfaces

Describe any new additions to the model, views or REST endpoints. Describe any changes to existing visualizations, dashboards and React components. Describe changes that affect the Superset CLI and how Superset is deployed.

New dependencies

Describe any npm/PyPI packages that are required. Are they actively maintained? What are their licenses?

Migration Plan and Compatibility

Describe any database migrations that are necessary, or updates to stored URLs.

Rejected Alternatives

Describe alternative approaches that were considered and rejected.

@villebro
Copy link
Member

Closing due to not being directly actionable. Please feel free to contact me on Slack if you want to discuss the topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants