Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] Filter unable to select NULL and empty string #18147

Closed
3 tasks done
zhaoyongjie opened this issue Jan 24, 2022 · 3 comments · Fixed by #18171
Closed
3 tasks done

[explore] Filter unable to select NULL and empty string #18147

zhaoyongjie opened this issue Jan 24, 2022 · 3 comments · Fixed by #18171
Labels
#bug Bug report validation:required A committer should validate the issue

Comments

@zhaoyongjie
Copy link
Member

zhaoyongjie commented Jan 24, 2022

I can't select NULL and empty string in Filter

How to reproduce the bug

  1. First of all, let us create a virtual dataset from SQLLab and open this in Explore page.
SELECT '' as name
UNION ALL
SELECT null as name
  1. I can't get NULL and empty string in filter.

image

  1. I can manually input <NULL> and <empty string> to filter that.

image

Expected results

I can select <NULL> and <empty string> in filter

Environment

latest master branch

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@zhaoyongjie zhaoyongjie added the #bug Bug report label Jan 24, 2022
@zhaoyongjie zhaoyongjie changed the title [explore] I can't select NULL and empty string in filter [explore] Filter can't select NULL and empty string Jan 24, 2022
@zhaoyongjie zhaoyongjie changed the title [explore] Filter can't select NULL and empty string [explore] Filter unable to select NULL and empty string Jan 24, 2022
@geido geido added the validation:required A committer should validate the issue label Jan 24, 2022
@jinghua-qa
Copy link
Member

I have tried using example dataset covid_vaccines, for the column with "null" value only, i did not see selection for IN filter, keep loading forever
Screen Shot 2022-01-24 at 8 32 24 PM

@zhaoyongjie
Copy link
Member Author

I have tried using example dataset covid_vaccines, for the column with "null" value only, i did not see selection for IN filter, keep loading forever Screen Shot 2022-01-24 at 8 32 24 PM

Thanks for you figure it out, but I think your finding is different with this issue. Feel free to open a new issue + ticket for can't load values in a filter.

@jinghua-qa
Copy link
Member

ok, i open this issue here #18178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report validation:required A committer should validate the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants