Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart d3-format currency configuration #24274

Closed
ekuziel opened this issue Jun 2, 2023 · 2 comments
Closed

Chart d3-format currency configuration #24274

ekuziel opened this issue Jun 2, 2023 · 2 comments
Labels
#bug Bug report

Comments

@ekuziel
Copy link

ekuziel commented Jun 2, 2023

I'm use superset container apache/superset where all resources are prepared and I want to change / add another d3-formats for numeric values like currencies Euro / Pound - currently I see only option $,.2f and I'm not able to edit it

How to reproduce the bug

  1. Go to 'Charts'
  2. Go to 'Customize' section and select in 'CUSTOMIZE COLUMNS' the numeric field and click an arrow
  3. popup for changing format will show

Expected results

to change interactively D3 format

Actual results

I can only select from existing list of options

Screenshots

image

Environment

Containerized solution apache/superset:2.1.0

@ekuziel ekuziel added the #bug Bug report label Jun 2, 2023
@rusackas
Copy link
Member

rusackas commented Jun 5, 2023

In D3 formatter syntax, the $ is just a placeholder for the currency symbol. You cannot just drop in another currency symbol for this. Instead you would do it with a D3 "locale" which is different from a formatter. You can set this for your entire superset instance in config.py if you're close to master (it has not been released in an official Apache version yet).

Given all that, just know that you're not alone... a lot of people are asking for this, and various folks are trying to find the best way forward with an implementation (cc @yousoph @mistercrunch)

For now, this all adds up to more of a feature request than a bug. I'll close this since there's already a discussion open.

@rusackas rusackas closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2023
@yousoph
Copy link
Member

yousoph commented Jul 26, 2023

#24718 and #24517 add support for more currency symbols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

3 participants