Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1.0rc1] Building Docker image from sources fails #29931

Closed
2 of 3 tasks
exolightor opened this issue Aug 13, 2024 · 3 comments
Closed
2 of 3 tasks

[4.1.0rc1] Building Docker image from sources fails #29931

exolightor opened this issue Aug 13, 2024 · 3 comments
Labels
install:docker Installation - docker container validation:required A committer should validate the issue

Comments

@exolightor
Copy link

Bug description

Hello Superset-Team,

we are trying to build the superset docker image from the pre-release 4.1.0rc on GitHub. Running docker build however leads to an error as seen below. This error also occurres in our CI environments. Will this be fixed in the next release?

How to reproduce the bug

  1. git clone https://github.com/apache/superset.git
  2. cd superset
  3. git checkout tags/4.1.0rc1
  4. docker build -t superset .

Screenshots/recordings

superset-docker

Superset version

master / latest-dev

Python version

3.9

Node version

18 or greater

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added install:docker Installation - docker container validation:required A committer should validate the issue labels Aug 13, 2024
Copy link

dosubot bot commented Aug 13, 2024

Hello @exolightor! I'm here to help you with any issues you encounter. Let's tackle this bug together!

The error you're encountering during the Docker build process for the pre-release version 4.1.0rc1 is due to a version mismatch between dayjs in package.json and package-lock.json. This issue can be resolved by synchronizing these files.

To fix this, follow these steps:

  1. Update package-lock.json:

    npm install
  2. Rebuild the Docker image:

    docker build -t superset .

This should resolve the version mismatch and allow the Docker build to complete successfully.

For more information on handling dependency version mismatches, you can refer to the recommended practices in the Superset repository [1].

To continue talking to Dosu, mention @dosu.

@exolightor
Copy link
Author

yes this workaround fixes it. Running npm install after deleting package-lock.json did not work for me but just running npm install did. Closing the issue.

@rusackas
Copy link
Member

This is odd... I didn't run into it. Please give 4.1.0rc2 a test for this when it comes out soon. When that happens, it'll be announced on the dev mailing list.

If you haven't already, you can subscribe to the Apache Superset Dev Mailing Listserv (dev@superset.apache.org, with public visibility here) by sending an email to dev-subscribe@superset.apache.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install:docker Installation - docker container validation:required A committer should validate the issue
Projects
None yet
Development

No branches or pull requests

2 participants