Scroll to top on Tab click

[rekilina]

Bug description

Steps to reproduce bag:

1. Create dashboard with nested tabs
2. Open dashboard and scroll down
3. Click on empty space inside the tab

Window will scroll to top.

Screenshots/recordings

Scroll.to.top.on.click.1080p.mp4

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Firefox

Additional context

It seems that problem originate from DashboardContainer.tsx file, onFocus prop of Tabs component.

Checklist

• I have searched Superset docs and Slack and didn't find a solution to my problem.
• I have searched the GitHub issue tracker and didn't find a similar bug report.
• I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[dosubot]

Hey @rekilina! I'm here to help you with any bugs, questions, or contributions you have in mind. Let's squash this bug together!

To address the issue of the window scrolling to the top when clicking on an empty space inside a tab, you can modify the onFocus event handler in the DashboardContainer.tsx file. The current implementation scrolls the window to the top if certain conditions are met. You can prevent this behavior by commenting out or removing the window.scrollTo line:

onFocus={e => {
  if (
    e.target.classList.contains('ant-tabs-tabpane') &&
    window.scrollY < TOP_OF_PAGE_RANGE
  ) {
    // Comment out or remove the following line to prevent scrolling
    // window.scrollTo(window.scrollX, 0);
  }
}}

This change will stop the window from scrolling to the top when the tab pane is focused ^[1].

To continue talking to Dosu, mention @dosu.