Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Lab horizontal resizer can be dragger past the bottom of the page #7383

Closed
3 tasks done
john-bodley opened this issue Apr 25, 2019 · 3 comments
Closed
3 tasks done
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@john-bodley
Copy link
Member

john-bodley commented Apr 25, 2019

In SQL Lab one can drag the horizontal resizer off the bottom of the page and there's no way to re-drag the resizer back. One needs to reload the page in order for the resizer to be repositioned.

Expected results

One should not be able to drag the resizer past the bottom of the page.

Actual results

It seems in some circumstances the resizer can be dragged past the bottom of the page and thus not recovered.

Screenshots

sql-lab-resizer-issue

How to reproduce the bug

  1. Go to SQL Lab.
  2. Drag the horizontal resizer past the bottom of the page (and release the mouse click).
  3. Observe there is no way to drag the resizer back.

Environment

(please complete the following information):

  • superset version: 0.31.0rc23 (Note this may be fixed in master).
  • python version: 3.6.8
  • node.js version: v10.15.0
  • npm version: 6.4.1

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

to: @enricoberti @vylc @xtinec

@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label Apr 25, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.95. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@michellethomas
Copy link
Contributor

This looks like it's fixed in master

@mistercrunch
Copy link
Member

That's right, couldn't reproduce this one in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

3 participants