Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RBAC]Remove share and favorite #9725

Closed
stefanmo opened this issue May 4, 2020 · 3 comments
Closed

[RBAC]Remove share and favorite #9725

stefanmo opened this issue May 4, 2020 · 3 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community .pinned Draws attention

Comments

@stefanmo
Copy link

stefanmo commented May 4, 2020

Is your feature request related to a problem? Please describe.
Remove the share and favorite buttons

Describe the solution you'd like
I would like to be able to remove the share and favorite buttons from the dashboards because in our implementation users will not have direct access to superset but thru iframes and custom authentication.

Describe alternatives you've considered
I have looked in other issues on github and read the documentation countless times but I could not find a solution.
Not adding the fave permissions only ends up in an error that says there is no access to the favorite list.

Additional context

@stefanmo stefanmo added the enhancement:request Enhancement request submitted by anyone from the community label May 4, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jul 3, 2020
@mistercrunch mistercrunch added the .pinned Draws attention label Jul 3, 2020
@stale stale bot removed the inactive Inactive for >= 30 days label Jul 3, 2020
@mistercrunch
Copy link
Member

Seems reasonable, it should show based on whether the user (or the Public role) has the right to do favorite or not.

@junlincc junlincc changed the title Remove share and favorite [RBAC]Remove share and favorite Apr 21, 2021
@junlincc
Copy link
Member

junlincc commented Apr 21, 2021

#10408 moving conversation to SIP-51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community .pinned Draws attention
Projects
None yet
Development

No branches or pull requests

3 participants