Skip to content

Commit

Permalink
Fixed column search filter in Delivery Service table (#7179)
Browse files Browse the repository at this point in the history
* Fixed value from a formatter to a getter.

* Updated Changelog
  • Loading branch information
rimashah25 authored Nov 8, 2022
1 parent a1a7dde commit 7157188
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- [#7037](https://github.com/apache/trafficcontrol/pull/7037) *Traffic Router* Uses Traffic Ops API 4.0 by default

### Fixed
- *Traffic Portal* Fixed search filter for Delivery Service Table
- *Traffic Portal* Fixed topologies sort (table and Delivery Service's form)
- [#5970](https://github.com/apache/trafficcontrol/issues/5970) *Traffic Portal* Fixed numeric sort in Delivery Service's form for DSCP
- [#5971](https://github.com/apache/trafficcontrol/issues/5971) *Traffic Portal* Fixed Max DNS Tool Top link to open in a new page
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function TableDeliveryServicesController(tableName, deliveryServices, steeringTa
headerName: "Geo Limit",
field: "geoLimit",
hide: true,
valueFormatter: params => deliveryServiceUtils.geoLimits[params.data.geoLimit],
valueGetter: params => deliveryServiceUtils.geoLimits[params.data.geoLimit],
tooltipValueGetter: params => deliveryServiceUtils.geoLimits[params.data.geoLimit]
},
{
Expand All @@ -139,7 +139,7 @@ function TableDeliveryServicesController(tableName, deliveryServices, steeringTa
headerName: "Geolocation Provider",
field: "geoProvider",
hide: true,
valueFormatter: params => deliveryServiceUtils.geoProviders[params.data.geoProvider],
valueGetter: params => deliveryServiceUtils.geoProviders[params.data.geoProvider],
tooltipValueGetter: params => deliveryServiceUtils.geoProviders[params.data.geoProvider]
},
{
Expand Down Expand Up @@ -261,21 +261,21 @@ function TableDeliveryServicesController(tableName, deliveryServices, steeringTa
headerName: "Protocol",
field: "protocol",
hide: false,
valueFormatter: params => deliveryServiceUtils.protocols[params.data.protocol],
valueGetter: params => deliveryServiceUtils.protocols[params.data.protocol],
tooltipValueGetter: params => deliveryServiceUtils.protocols[params.data.protocol]
},
{
headerName: "Qstring Handling",
field: "qstringIgnore",
hide: true,
valueFormatter: params => deliveryServiceUtils.qstrings[params.data.qstringIgnore],
valueGetter: params => deliveryServiceUtils.qstrings[params.data.qstringIgnore],
tooltipValueGetter: params => deliveryServiceUtils.qstrings[params.data.qstringIgnore]
},
{
headerName: "Range Request Handling",
field: "rangeRequestHandling",
hide: true,
valueFormatter: params => deliveryServiceUtils.rrhs[params.data.rangeRequestHandling],
valueGetter: params => deliveryServiceUtils.rrhs[params.data.rangeRequestHandling],
tooltipValueGetter: params => deliveryServiceUtils.rrhs[params.data.rangeRequestHandling]
},
{
Expand Down

0 comments on commit 7157188

Please sign in to comment.