Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update SSL keys on a delivery service does not create change log entry #5339

Closed
mitchell852 opened this issue Dec 1, 2020 · 4 comments · Fixed by #5423
Closed

Add/update SSL keys on a delivery service does not create change log entry #5339

mitchell852 opened this issue Dec 1, 2020 · 4 comments · Fixed by #5423
Assignees
Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops

Comments

@mitchell852
Copy link
Member

mitchell852 commented Dec 1, 2020

I'm submitting a ...

  • improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

It appears that the following route does not create a change log entry:

{api.Version{3, 0}, http.MethodPost, `deliveryservices/sslkeys/add$`, deliveryservice.AddSSLKeys, auth.PrivLevelAdmin, Authenticated, nil, 28728785833, noPerlBypass},

New behavior:

Exercise the following API route successfully:

{api.Version{3, 0}, http.MethodPost, `deliveryservices/sslkeys/add$`, deliveryservice.AddSSLKeys, auth.PrivLevelAdmin, Authenticated, nil, 28728785833, noPerlBypass},

and ensure an message like this is created:

DS: testqa, ID: 372, ACTION: Added/updated SSL keys

You should see the new entry here:

GET api/3.0/logs

Minimal reproduction of the problem with instructions:

Hit the route. If it didn't create a change log entry, it needs one.

Anything else:

Also, this endpoint:

{api.Version{3, 0}, http.MethodPost, `deliveryservices/sslkeys/generate/?$`, deliveryservice.GenerateSSLKeys, auth.PrivLevelOperations, Authenticated, nil, 2534390513, noPerlBypass},

should create an change log like:

DS: testqa, ID: 372, ACTION: Generated SSL keys
@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops good first issue first-time committers will find this easy to resolve improvement The functionality exists but it could be improved in some way. bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one and removed improvement The functionality exists but it could be improved in some way. labels Dec 1, 2020
@tcfdev
Copy link
Collaborator

tcfdev commented Dec 17, 2020

I got this one

@mitchell852
Copy link
Member Author

Actually, looks like generate is working:

DS: testqa, ID: 372, ACTION: Added SSL keys

Maybe that can simply be changed to "Generated SSL keys" instead of "Added"

@mitchell852
Copy link
Member Author

but

deliveryservices/sslkeys/add

is definitely not working.

@mitchell852
Copy link
Member Author

and this works too

DS: testqa, ID: 372, ACTION: Deleted SSL keys

i'll update the issue

@mitchell852 mitchell852 changed the title Add/update/delete/generate SSL keys on a delivery service does not create change log entry Add/update SSL keys on a delivery service does not create change log entry Jan 4, 2021
@zrhoffman zrhoffman mentioned this issue Jul 8, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants