Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error message when creating a DS with insufficient Tenancy #7321

Open
ocket8888 opened this issue Jan 28, 2023 · 1 comment · May be fixed by #7848
Open

Incorrect error message when creating a DS with insufficient Tenancy #7321

ocket8888 opened this issue Jan 28, 2023 · 1 comment · May be fixed by #7848
Labels
bug something isn't working as intended low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops

Comments

@ocket8888
Copy link
Contributor

This Bug Report affects these Traffic Control components:

  • Traffic Ops

Current behavior:

When creating a new Delivery Service, if tenantId is omitted (and probably also in the case that it's simply outside of the user's Tenant's access), Traffic Ops will respond with a 500 Internal Server Error after failing to check Tenancy.

Expected behavior:

The issue is with the client's request, so the response should be a 400 Bad Request along with an error message telling me what I did wrong.

Steps to reproduce:

Assuming 8 is the ID of ANY_MAP and no DS with the XMLID "test" already exists: topost -kpa 3.1 deliveryservices '{"xmlId": "test", "displayName": "test", "protocol": 0, "typeId": 8, "dscp": 0}'
@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one low difficulty the estimated level of effort to resolve this issue is low labels Jan 28, 2023
@ntheanh201 ntheanh201 linked a pull request Oct 24, 2023 that will close this issue
Open
4 tasks
@ntheanh201
Copy link
Contributor

@ocket8888 Please take a look at my PR: #7848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working as intended low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Incorrect error message when creating a DS with insufficient Tenancy ntheanh201/trafficcontrol
2 participants
@ocket8888 @ntheanh201