Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes click functions on server ip addresses in the server table #5519

Merged
merged 5 commits into from
Feb 16, 2021
Merged

Fixes click functions on server ip addresses in the server table #5519

merged 5 commits into from
Feb 16, 2021

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Feb 15, 2021 •
edited
Loading

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  • Navigate to https://tp.domain.tld/#!/servers
  • The following IP addresses are clickable links and will do the following:
    -- IPv4 Address (ssh://to_username@ip)
    -- IPv6 Address (ssh://to_username@ip)
    -- Mgmt IP Address (ssh://to_username@ip)
    -- ILO IP (https://iloip)
  • The remaining IP addresses are not links (IPv4 Gateway, IPv4 Subnet, IPv6 Gateway, Mgmt IP Gateway, Mgmt IP Netmask, ILO IP Gateway, ILO IP Netmask)

^^ clicking any of those IPs will NOT however navigate you to the server details page which was the bug.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added regression bug a bug in existing functionality introduced by a new version Traffic Portal v1 related to Traffic Portal version 1 labels Feb 15, 2021
@mitchell852 mitchell852 marked this pull request as ready for review February 15, 2021 21:09
@mitchell852 mitchell852 changed the title Fixes click functions on server ip addresses Fixes click functions on server ip addresses in the server table Feb 15, 2021
@mitchell852 mitchell852 added this to the 5.1.0 milestone Feb 15, 2021
shamrickus
shamrickus approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocket8888 ocket8888 merged commit 6b02ba8 into apache:master Feb 16, 2021
ocket8888 pushed a commit that referenced this pull request Feb 18, 2021
@mitchell852 @ocket8888
Fixes click functions on server ip addresses in the server table (#5519)
70b0e7e 
* on server ip click do not navigate to server detail page

* adds SSHCellRenderer to the appropriate server fields

* changes ilo ip to use https rather than ssh

* fixes case

* adds changelog entry

(cherry picked from commit 6b02ba8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamrickus shamrickus shamrickus approved these changes

Assignees
No one assigned
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

TO pre 5.0 server list, network ip and ilo ip were clickable without going into server details.
3 participants
@mitchell852 @shamrickus @ocket8888