-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPv2 Update Angular and make compilation stricter #6391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
low impact
affects only a small portion of a CDN, and cannot itself break one
tech debt
rework due to choosing easy/limited solution
experimental
a feature/component not directly supported by ATC
labels
Dec 2, 2021
I know this PR looks big, but 49.k lines of changes are coming from just package-lock.json. |
shamrickus
reviewed
Dec 2, 2021
shamrickus
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zrhoffman
added
the
Traffic Portal v2
Related to the experimental Traffic Portal version 2
label
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
experimental
a feature/component not directly supported by ATC
low impact
affects only a small portion of a CDN, and cannot itself break one
tech debt
rework due to choosing easy/limited solution
Traffic Portal v2
Related to the experimental Traffic Portal version 2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Angular to version 13 (13.0.3 at the time of this writing) for TPv2, and adds some options to get type-checking in templates, as well as adding some more strict type checking generically. Mostly changes that needed to made to make it compile came from the strict template typing. And the fact that it was using a "user" as the same thing as a "current user", which unfortunately cannot be safely done (see #6299).
This also fixes some broken tests from the module restructure done in #6263, and squashes an error about Chart JS being bulky and causing optimization problems. That's all true, but we know about it, so there's no reason to see a warning on every compilation.
Also, the new version of Angular allows the use of ES2020 in source, and because IE is dead and Edge is now Chromium-based, our output has moved up to ES2017, which is nice.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the unit and end-to-end tests pass. Also probably play around with the UI a bit, because our end-to-end tests only cover the login page.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist