Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPv2 Update Angular and make compilation stricter #6391

Merged
merged 15 commits into from
Dec 17, 2021

Conversation

ocket8888
Copy link
Contributor

This PR updates Angular to version 13 (13.0.3 at the time of this writing) for TPv2, and adds some options to get type-checking in templates, as well as adding some more strict type checking generically. Mostly changes that needed to made to make it compile came from the strict template typing. And the fact that it was using a "user" as the same thing as a "current user", which unfortunately cannot be safely done (see #6299).

This also fixes some broken tests from the module restructure done in #6263, and squashes an error about Chart JS being bulky and causing optimization problems. That's all true, but we know about it, so there's no reason to see a warning on every compilation.

Also, the new version of Angular allows the use of ES2020 in source, and because IE is dead and Edge is now Chromium-based, our output has moved up to ES2017, which is nice.


Which Traffic Control components are affected by this PR?

  • Traffic Portal (experimental v2)

What is the best way to verify this PR?

Make sure the unit and end-to-end tests pass. Also probably play around with the UI a bit, because our end-to-end tests only cover the login page.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master, but who cares, it's experimental

PR submission checklist

  • This PR has tests
  • This PR has documentation
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution experimental a feature/component not directly supported by ATC labels Dec 2, 2021
@ocket8888 ocket8888 requested a review from shamrickus December 2, 2021 17:23
@ocket8888
Copy link
Contributor Author

I know this PR looks big, but 49.k lines of changes are coming from just package-lock.json.

Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamrickus shamrickus merged commit 95189ff into apache:master Dec 17, 2021
@ocket8888 ocket8888 deleted the tpv2/strict-templates branch December 17, 2021 17:39
@ocket8888 ocket8888 mentioned this pull request Dec 17, 2021
4 tasks
@zrhoffman zrhoffman added the Traffic Portal v2 Related to the experimental Traffic Portal version 2 label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental a feature/component not directly supported by ATC low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Portal v2 Related to the experimental Traffic Portal version 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants