Tpv2/password reset #6435
Merged
Tpv2/password reset #6435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
new feature
ocket8888
force-pushed
the
tpv2/password-reset
branch
from
280dfdb to
485f398
Compare
shamrickus
requested changes
Jan 6, 2022
There was a problem hiding this comment.
Checks are failing, potentially related to the two failing tests I'm getting:
LoginComponent > should exist
NullInjectorError: R3InjectorError(DynamicTestModule)[MatDialog -> MatDialog]:
NullInjectorError: No provider for MatDialog!
ResetPasswordDialogComponent > should create
NullInjectorError: R3InjectorError(DynamicTestModule)[UserService -> UserService]:
NullInjectorError: No provider for UserService!
(also exposed in the current user service)
ocket8888
force-pushed
the
tpv2/password-reset
branch
from
00447dd to
4ac965a
Compare
zrhoffman
added
the
authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Reset Password" button to TPv2, and fixes some slow compilation caused by #6391.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the TPv2 tests all still pass
The way I tested this was to make sure the button called the right API endpoint, and then going to
/login?token={{My user's token in the database}}since this doesn't change the behavior of that endpoint there's no point I can see to going to the trouble of getting it to actually send an email.PR submission checklist