-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes alert message for POST and PUT invalidationjobs API #7517
Fixes alert message for POST and PUT invalidationjobs API #7517
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7517 +/- ##
=============================================
- Coverage 65.10% 30.26% -34.85%
Complexity 98 98
=============================================
Files 309 789 +480
Lines 11934 82551 +70617
Branches 840 840
=============================================
+ Hits 7770 24980 +17210
- Misses 3816 55467 +51651
- Partials 348 2104 +1756
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 481 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
e17150b
to
5199ac8
Compare
traffic_ops/traffic_ops_golang/invalidationjobs/invalidationjobs.go
Outdated
Show resolved
Hide resolved
5199ac8
to
4e6eeef
Compare
I've restarted the t3c tests and they just failed again. They're passing consistently on master, so I'm not sure why but I think it's a real error? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that this fixes the error messages. I have no idea how changing an error message is causing Traffic Portal and T3C integration tests to fail, and I can't get them to work well enough to troubleshoot outside of actions, so I'm going to just ignore the problem and hope it goes away. If not, then hopefully it'll at least annoy someone who can fix it.
Closes: #6340
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Create an invalidation job (
REFETCH
) withoutrefetch_enabled
parameter and check the new message.Create an invalidation job (
REFRESH
) withoutrefetch_enabled
parameter or refetch_enabled parameter value set tofalse
and then using PUT API try and change the job fromREFRESH
toREFETCH
.If this is a bugfix, which Traffic Control versions contained the bug?
7.0.1
PR submission checklist