Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to queue/dequeue revalidations on servers #7923

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ocket8888
Copy link
Contributor

Closes #2856

This PR adds context menu options to the servers table in TPv2 that allow for quick and easy queuing/dequeuing revalidations on a group of one or more servers.

I also plugged a testing gap in the servers API service - Capability-related methods were untested.


Which Traffic Control components are affected by this PR?

  • Traffic Portal (experimental v2)

What is the best way to verify this PR?

Make sure the provided e2e and unit tests pass. Queue/Dequeue updates on some server(s).

PR submission checklist

  • This PR has tests
  • This PR doesn't need documentation
  • This PR doesn't need a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added new feature A new feature, capability or behavior low impact affects only a small portion of a CDN, and cannot itself break one experimental a feature/component not directly supported by ATC Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (0b802b5) 65.65% compared to head (bf9d673) 65.73%.

Files Patch % Lines
...affic-portal/src/app/api/testing/server.service.ts 0.00% 12 Missing ⚠️
...e/servers/servers-table/servers-table.component.ts 80.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7923      +/-   ##
============================================
+ Coverage     65.65%   65.73%   +0.07%     
  Complexity       98       98              
============================================
  Files           323      323              
  Lines         12840    12863      +23     
  Branches        970      975       +5     
============================================
+ Hits           8430     8455      +25     
+ Misses         4050     4048       -2     
  Partials        360      360              
Flag Coverage Δ
traffic_portal_v2 74.52% <57.14%> (+0.14%) ⬆️
unit_tests 74.52% <57.14%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocket8888
Copy link
Contributor Author

Depends on #7925

@ocket8888 ocket8888 marked this pull request as draft January 23, 2024 20:38
@ocket8888 ocket8888 marked this pull request as ready for review January 23, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental a feature/component not directly supported by ATC low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Traffic Portal v2 Related to the experimental Traffic Portal version 2
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Add the ability to trigger a global reval on all caches for a given CDN
1 participant