update GH actions to change go version in go.mod file #8108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrhoffman
added
improvement
zrhoffman
reviewed
Dec 27, 2024
| @@ -17,7 +17,7 @@ module github.com/apache/trafficcontrol/v8 | |||
| // specific language governing permissions and limitations | |||
| // under the License. | |||
|
|
|||
| go 1.23.0 | |||
| go 1.23.4 | |||
There was a problem hiding this comment.
Hmm, this will mean that a user cannot compile ATC using Go 1.23.3, and Go 1.23.4 or higher is required. Usually, minor versions are bugfixes and Go language changes are only introduced in major versions, so do we want to require specific minor versions?
There was a problem hiding this comment.
My reason is for aligning the Go version with .env and GO_VERSION is to maintain consistency across the development environment and avoid potential version mismatches.
I understand your perspective about not wanting to be overly restrictive with minor versions.
Would it better if we only watch & change the major/minor versions, and the patch keep 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist