Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] relay.Var allows special characters like : while chose are not allowed in the compiler #13063

Closed
mehrdadh opened this issue Oct 13, 2022 · 3 comments
Labels

Comments

@mehrdadh
Copy link
Member

In the current TVM, relay.Var would accept variable names like input:0 while in the compiler : is a special character and we are sanitizing these name before passing it to the compiler.

The solution could be adding check in the relay.Var itself. This would result in adding sanitization in different places like frontends.

cc @AndrewZhaoLuo @slyubomirsky @areusch

@mehrdadh mehrdadh added type: bug needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 13, 2022
@AndrewZhaoLuo
Copy link
Contributor

I say just put the sanitation in relay.Var, make it automatic and call it a day B).

@areusch areusch added relay:ir src/relay/ir and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 17, 2022
@AndrewZhaoLuo
Copy link
Contributor

@mehrdadh is this issue closed with #13046 ?

@mehrdadh
Copy link
Member Author

@AndrewZhaoLuo no, I have a follow up draft PR which should fix this as you suggested
#13086

@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
@areusch areusch removed the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Nov 22, 2022
@tqchen tqchen closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants