-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoTVM] Introducing multi_filter into ConfigSpace autotvm #12545
Conversation
1585196
to
6578df8
Compare
CC @merrymercy @eqy |
cc @csullivan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly looked into this PR. I don't really like that now we need to call tsk.config_space.filtered_length
instead of len(tsk.config_space)
. I think that len(smth)
is more intuitive. But I didn't dive deeply into the details. I'll do it later. I think that @elvin-n can provide more useful and detailed review.
5da9a68
to
5b85a2d
Compare
bb9c460
to
c800055
Compare
c800055
to
011b59e
Compare
Co-authored-by: Andrey Malyshev elvin.nnov@gmail.com Co-authored-by: Egor Churaev egor.churaev@gmail.com
011b59e
to
e88f350
Compare
e88f350
to
7c68a30
Compare
7c68a30
to
bbbed0f
Compare
@masahi @merrymercy could you please take a look? |
CC @tqchen @merrymercy this PR makes some in depth changes to autoTVM, PTAL |
can we merge this PR into main? |
…2545) * [AutoTVM] Introducing multi_filter into ConfigSpace autotvm Co-authored-by: Andrey Malyshev elvin.nnov@gmail.com Co-authored-by: Egor Churaev egor.churaev@gmail.com * update multi_filter for adreno conv's
multi_filter can restrict combination of parameters in difference to the knob filter, that restricts only single parameter.
Here is a small example to show the workflow and the difference:
Pre-requisites
Case 1 - without filtering
Case 2 - with filter
Case 3 - with filter and multi_filter
Co-authored-by: Andrey Malyshev elvin.nnov@gmail.com
Co-authored-by: Egor Churaev egor.churaev@gmail.com