[CMSIS-NN] Support for int16 conv2d #12950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Pattern matching and RelayToTIR introduce int16 support -Added new context buffer size APIs for int16 Conv2d -Added int16 variants to integration and buffer size tests Change-Id: I6083ea20b9125a9700a69a93c52c07eb463618b2
lhutton1
reviewed
Sep 30, 2022
| groups = 1 | ||
| weight_format = "HWIO" | ||
| input_zero_point = input_zero_point if dtype == "int8" else 0 |
There was a problem hiding this comment.
Curious, why is this needed?
There was a problem hiding this comment.
input_zero_point is not supported by TFLM when dtype == int16. I've added a comment about it. Thanks for pointing out.
There was a problem hiding this comment.
Ah I see thanks! Seems like there should be a check in the partitioning for this case
Change-Id: I1956107ff4a52437a525aa34c746acc5e3a31631
Change-Id: I62e67fdbe2781c90e55028ff2da88789623f269a
|
Thanks @lhutton1 for the review comments. I have added a check for input_zero_point in the partitioner. Could you please take another look? |
lhutton1
approved these changes
Oct 4, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Support for int16 Conv2d via CMSIS-NN -Pattern matching and RelayToTIR introduce int16 support -Added new context buffer size APIs for int16 Conv2d -Added int16 variants to integration and buffer size tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for int16 Conv2d via CMSIS-NN
-Pattern matching and RelayToTIR introduce int16 support
-Added new context buffer size APIs for int16 Conv2d
-Added int16 variants to integration and buffer size tests
cc @lhutton1 @Mousius @leandron @grant-arm