[AOT] Fix warning on dropping const in TVMAotExecutor_GetInputName #14529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `TVMAotExecutor_GetInputName` function accepted a `char** name` output parameter. When used, assignment of a `const char*` into `*name` dropped the `const`, resulting in a warning. Changing the argument type to `const char**` (pointer to a mutable pointer to a `const char`) resolves this warning.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
kparzysz-quic
approved these changes
Apr 13, 2023
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Jul 5, 2023
The `TVMAotExecutor_GetInputName` function requires a `const char**`, but is provided with a `char**`. While C's automatic pointer conversion does allow this as an automatic conversion, following const-correctness avoids a compile-time warning. This warning was first caused following apache#14529, which itself was to follow const-correctness within the implementation of `TVMAotExecutor_GetInputName`.
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
May 23, 2024
The `TVMAotExecutor_GetInputName` function requires a `const char**`, but is provided with a `char**`. While C's automatic pointer conversion does allow this as an automatic conversion, following const-correctness avoids a compile-time warning. This warning was first caused following apache#14529, which itself was to follow const-correctness within the implementation of `TVMAotExecutor_GetInputName`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
TVMAotExecutor_GetInputNamefunction accepted achar** nameoutput parameter. When used, assignment of aconst char*into*namedropped theconst, resulting in a warning. Changing the argument type toconst char**(pointer to a mutable pointer to aconst char) resolves this warning.