-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docker] Install oneflow from PyPi #15819
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing oneflow from the current link (https://release.oneflow.info) seems to be broken as reported in apache#15754, which is impacting other unrelated changes in CI. This commit attempts to fix the install by using a version from PyPi. Change-Id: If032923876eac98738b09d4f1a8a3af157f00ab3
ashutosh-arm
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lhutton1. LGTM!
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Sep 28, 2023
The ci-gpu is updated to make changes in apache#15819 reflect in CI. Change-Id: I5370f80fa82839a8e2f97cf3de9bd1ede7e2d350
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Oct 3, 2023
The PR apache#15819 installed oneflow from PyPi in an attempt to unblock CI failing on the gpu docker image build. However, it seems to be a placeholder package. This PR upgrades the version of oneflow to v0.8.0 in a second attempt to unblock CI. Change-Id: I92bcc6aee79dfcbeba7c13cf0b6d91104be16f5c
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Oct 3, 2023
The PR apache#15819 installed oneflow from PyPi in an attempt to unblock CI failing on the gpu docker image build. However, it seems to be a placeholder package. This PR upgrades the version of oneflow to v0.8.0 in a second attempt to unblock CI. Change-Id: I92bcc6aee79dfcbeba7c13cf0b6d91104be16f5c
leandron
pushed a commit
that referenced
this pull request
Oct 4, 2023
The PR #15819 installed oneflow from PyPi in an attempt to unblock CI failing on the gpu docker image build. However, it seems to be a placeholder package. This PR upgrades the version of oneflow to v0.8.0 in a second attempt to unblock CI. Change-Id: I92bcc6aee79dfcbeba7c13cf0b6d91104be16f5c
ashutosh-arm
pushed a commit
that referenced
this pull request
Oct 6, 2023
* [CI] Update ci-gpu image The ci-gpu is updated to make changes in #15819 reflect in CI. * update image that contains oneflow==0.8.0 * Force old coreml api to fix failing test Between the previous ci_gpu image and the one in use now, the version of coreml has changed since it is unpinned (6.3.0 -> 7.0.0). This caused a test failure in the coreml frontend tests. The problem is that coreml now uses a new default format for models. This commit forces coreml to use the old model format so the test passes. More information can be found here: https://apple.github.io/coremltools/docs-guides/source/convert-learning-models.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing oneflow from the current link (https://release.oneflow.info) seems to be broken as reported in #15754, which is impacting other unrelated changes in CI. This commit attempts to fix the install by using a version from PyPi.