[Fix] Fix the purity flag of "vm.call_tir_dyn" and "kill" ops #16773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Mar 23, 2024
This PR fixes the purity flag of `relax.vm.call_tir_dyn` and another few "kill" ops. Their purity flags were set to True, which made them possible to be removed by `remove_all_unused`. * `relax.vm.call_tir_dyn` works by mutating the input args in place, which is not pure. * though the "kill" ops have no actions so far, their semantics suggest that they are impure. A regression test is added to prevent the unexpected removal from happening again.
MasterJH5574
force-pushed
the
tvm-dev/2024-03-22-purity-flag
branch
from
1f5733c to
cf4d113
Compare
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
…#16773) This PR fixes the purity flag of `relax.vm.call_tir_dyn` and another few "kill" ops. Their purity flags were set to True, which made them possible to be removed by `remove_all_unused`. * `relax.vm.call_tir_dyn` works by mutating the input args in place, which is not pure. * though the "kill" ops have no actions so far, their semantics suggest that they are impure. A regression test is added to prevent the unexpected removal from happening again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the purity flag of
relax.vm.call_tir_dynand another few "kill" ops. Their purity flags were set to True, which made them possible to be removed byremove_all_unused.relax.vm.call_tir_dynworks by mutating the input args in place, which is not pure.A regression test is added to prevent the unexpected removal from happening again.