[Disco][QoL] Implement broadcast/scatter methods for Session #17035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is identical to the now-closed PR #17011, as a CI restart prevented the CI from running on the original PR. |
Prior to this commit, use of the `disco.Session` API to broadcast or scatter an array required several steps from the caller. 1. Allocate memory on worker0 2. Transfer data from the controller to worker0 3. Allocate memory on each worker 4. Broadcast/scatter data from worker0 to all workers While exposing these steps is necessary for performance, especially when used repeatedly, it can be tedious/error-prone to use for initialization that is only performed once. This commit adds utility methods `Session.broadcast` and `Session.scatter`, which are implemented in terms of the existing lower-level methods `Session.broadcast_from_worker0` and `Session.scatter_from_worker0`. These methods perform the transfer from the controller to worker0, and from worker0 to all other workers.
Lunderberg
force-pushed
the
disco_broadcast_scatter_utility_methods
branch
from
e2cb9e7 to
f7a9fc7
Compare
tqchen
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, use of the
disco.SessionAPI to broadcast or scatter an array required several steps from the caller.While exposing these steps is necessary for performance, especially when used repeatedly, it can be tedious/error-prone to use for initialization that is only performed once.
This commit adds utility methods
Session.broadcastandSession.scatter, which are implemented in terms of the existing lower-level methodsSession.broadcast_from_worker0andSession.scatter_from_worker0. These methods perform the transfer from the controller to worker0, and from worker0 to all other workers.