[WebGPU] Translate int8x4 into u32
#17071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch translates an `int8x4` into a `u32` in WGSL shaders as 8-bit integers are not supported in WebGPU right now and the WGSL built-in function `dot4I8Packed()` accepts `u32` as its inputs and each of the `u32` value logically represents a 4-element 8-bit integer vector. issue: apache#16627
|
Hi @tqchen I'd like to submit this part first then work on adding DP4A in TIR. |
tqchen
approved these changes
Jun 7, 2024
|
thank you @Jiawei-Shao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch translates an
int8x4into au32in WGSL shaders as 8-bit integers are not supported in WebGPU right now and the WGSL built-in functiondot4I8Packed()acceptsu32as its inputs and each of theu32value logically represents a 4-element 8-bit integer vector.issue: #16627