Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reconfigure fetch original value #8688

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

kizuna-lek
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.76%. Comparing base (2977d6c) to head (ebfa0ac).
Report is 2 commits behind head on release-0.9.

Files with missing lines Patch % Lines
controllers/apps/operations/reconfigure_util.go 41.66% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8688      +/-   ##
===============================================
+ Coverage        64.69%   64.76%   +0.07%     
===============================================
  Files              359      359              
  Lines            45971    45978       +7     
===============================================
+ Hits             29741    29778      +37     
+ Misses           13567    13543      -24     
+ Partials          2663     2657       -6     
Flag Coverage Δ
unittests 64.76% <41.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kizuna-lek kizuna-lek linked an issue Dec 23, 2024 that may be closed by this pull request
@kizuna-lek kizuna-lek requested a review from sophon-zt December 23, 2024 09:58
@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 23, 2024
@kizuna-lek kizuna-lek merged commit 5963d59 into release-0.9 Dec 23, 2024
39 checks passed
@kizuna-lek kizuna-lek deleted the bugfix/reconfigure-fetch-oriValue branch December 23, 2024 10:15
@github-actions github-actions bot added this to the Release 0.9.2 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reconfigure get wrong original value in 0.9
4 participants