Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: annotation key to skip the pre-terminate action #8689

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

leon-inf
Copy link
Contributor

close #8679

@leon-inf leon-inf added this to the Release 1.0.0 milestone Dec 23, 2024
@leon-inf leon-inf requested review from Y-Rookie and a team as code owners December 23, 2024 07:29
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.96%. Comparing base (7b5e921) to head (1c33895).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ollers/apps/transformer_component_pre_terminate.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8689      +/-   ##
==========================================
+ Coverage   60.50%   60.96%   +0.46%     
==========================================
  Files         378      378              
  Lines       45627    45881     +254     
==========================================
+ Hits        27605    27970     +365     
+ Misses      15421    15296     -125     
- Partials     2601     2615      +14     
Flag Coverage Δ
unittests 60.96% <0.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 26, 2024
@leon-inf leon-inf merged commit 0f70801 into main Dec 26, 2024
39 checks passed
@leon-inf leon-inf deleted the support/skip-pre-terminate branch December 26, 2024 02:30
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12498726698

apecloud-bot pushed a commit that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Cluster deletion stuck while addon defined preTerminate but pod couldn't startup
4 participants