Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type comment on Chart Objects (#825) #860

Merged
merged 1 commit into from
May 25, 2022

Conversation

yoooz
Copy link
Contributor

@yoooz yoooz commented May 23, 2022

Fix: add type comment on Chart Objects

Fixed #825

Add type comment on Chart Objects.

Emitted definitions are typed, by regarding Chart Objects (e.g. Bar, Bubble) as a Object

  • All tests passed

Environment

  • OS: macOS 12.0.1
  • NPM Version: 8.5.5

@yoooz
Copy link
Contributor Author

yoooz commented May 25, 2022

@apertureless

Please give me a permission to run workflows?

And tell me how going a head this pull request.

Sorry for being a beginner...

@apertureless apertureless merged commit 2311361 into apertureless:main May 25, 2022
@yoooz yoooz deleted the develop branch November 25, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Vue2 Legacy missing typescript definitions
2 participants