Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect back #3

Closed
tj opened this issue Jul 3, 2017 · 6 comments
Closed

Redirect back #3

tj opened this issue Jul 3, 2017 · 6 comments

Comments

@tj
Copy link
Member

tj commented Jul 3, 2017

Something funky happening when redirecting back to referer, need to look into it, seems to rediect right back to /vote for whatever reason.

@lukeed
Copy link

lukeed commented Jul 3, 2017

Since you know the requesting URL, can change the Voted text response to a mini HTML page with a redirect on setTimeout. Not the most elegant solution, but a quick sumthin-sumthin' for time being.

@tj
Copy link
Member Author

tj commented Jul 3, 2017

That might be less jarring than an instant redirect anyway :D

@tj tj closed this as completed in 7f28be1 Jul 4, 2017
@tj
Copy link
Member Author

tj commented Jul 4, 2017

referrer was just https://github.com for private repos, so just doing history.back() for now anyway.

screen shot 2017-07-04 at 3 56 02 pm

@tj
Copy link
Member Author

tj commented Jul 4, 2017


@lukeed
Copy link

lukeed commented Jul 4, 2017

The only issue with history.back is that it will always serve the cached chart -- aka my vote doesnt appear.

What if redirected via window.location and added a silly query string; ?voted. Will force a non-cache load.

@tj
Copy link
Member Author

tj commented Jul 4, 2017

true true, sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants