Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staticcheck: SA1019 (deprecated dependency) #749

Closed
timburks opened this issue Sep 16, 2022 · 3 comments
Closed

staticcheck: SA1019 (deprecated dependency) #749

timburks opened this issue Sep 16, 2022 · 3 comments
Labels
code quality Linting, testing, and other code quality issues dependency There's something we need addressed in a dependency

Comments

@timburks
Copy link
Contributor

cmd/registry/cmd/rpc/generated/apg.go:11:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/apg.go:12:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/create-api-deployment.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/create-api-spec.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/create-api-version.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/create-api.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/create-artifact.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/create-instance.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/create-project.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/delete-api-deployment-revision.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/delete-api-deployment.go:8:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/delete-api-spec-revision.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/delete-api-spec.go:8:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/delete-api-version.go:8:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/delete-api.go:8:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/delete-artifact.go:8:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/delete-instance.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/delete-project.go:8:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/get-api-deployment.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/get-api-spec-contents.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/get-api-spec.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/get-api-version.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/get-api.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/get-artifact-contents.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/get-artifact.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/get-instance.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/get-project.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/list-api-deployment-revisions.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/list-api-deployments.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/list-api-spec-revisions.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/list-api-specs.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/list-api-versions.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/list-apis.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/list-artifacts.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/list-projects.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/migrate-database.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/replace-artifact.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/rollback-api-deployment.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/rollback-api-spec.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/tag-api-deployment-revision.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/tag-api-spec-revision.go:10:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/update-api-deployment.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/update-api-spec.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/update-api-version.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/update-api.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/cmd/rpc/generated/update-project.go:12:2: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (SA1019)
cmd/registry/scoring/expression_test.go:21:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead. (SA1019)
cmd/registry/scoring/score_test.go:26:2: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead. (SA1019)
@timburks timburks mentioned this issue Sep 17, 2022
Open
@timburks
Copy link
Contributor Author

timburks commented Sep 17, 2022 •
edited
Loading

These are mostly in generated code, but there are a couple of instances of this in the scoring package. @shrutiparabgoogle could you address those with a PR and then assign this back to me to address the rest in the generator?

@timburks timburks added enhancement New feature or request dependency There's something we need addressed in a dependency labels Sep 17, 2022
@timburks timburks added code quality Linting, testing, and other code quality issues and removed enhancement New feature or request labels Sep 17, 2022
@timburks timburks mentioned this issue Sep 17, 2022
Open
@shrutiparabgoogle shrutiparabgoogle mentioned this issue Sep 23, 2022
Merged
@shrutiparabgoogle
Copy link
Contributor

Assigning back to @timburks

@timburks timburks removed their assignment Nov 16, 2022
@timburks timburks moved this to Todo in Apigee API Registry Apr 5, 2023
@timburks timburks moved this from Todo to Backlog in Apigee API Registry Apr 5, 2023
@theganyo
Copy link
Member

external issue

@theganyo theganyo closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Apigee API Registry Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Linting, testing, and other code quality issues dependency There's something we need addressed in a dependency
Projects
Apigee API Registry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timburks @theganyo @shrutiparabgoogle