From 1a23719f900f499b3fef5f71bd1a647c15a047e0 Mon Sep 17 00:00:00 2001 From: Sashko Stubailo Date: Mon, 23 May 2016 10:29:54 -0700 Subject: [PATCH 1/4] Add more color to comment --- src/QueryManager.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/QueryManager.ts b/src/QueryManager.ts index 1fdfb5b4eb2..04add96ee6b 100644 --- a/src/QueryManager.ts +++ b/src/QueryManager.ts @@ -431,6 +431,7 @@ export class QueryManager { const queries = this.getApolloState().queries; forOwn(this.queryListeners, (listener: QueryListener, queryId: string) => { // it's possible for the listener to be undefined if the query is being stopped + // See here for more detail: https://github.com/apollostack/apollo-client/issues/231 if (listener) { const queryStoreValue = queries[queryId]; listener(queryStoreValue); From 09e68814b407c65d139086fea862c6c21bda5210 Mon Sep 17 00:00:00 2001 From: Sashko Stubailo Date: Mon, 23 May 2016 10:30:37 -0700 Subject: [PATCH 2/4] Update changelog with more detail --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b93cc0a60f3..e36f5ac07a6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ Expect active development and potentially significant breaking changes in the `0 ### vNEXT -- Resolve a race condition between `QueryManager` `stopQuery()` and `broadcastQueries()`. [Issue #231](https://github.com/apollostack/apollo-client/issues/231) [PR #232](https://github.com/apollostack/apollo-client/pull/232) +- Resolve a race condition between `QueryManager` `stopQuery()` and `broadcastQueries()`, which would result in an error `listener is not a function`. [Issue #231](https://github.com/apollostack/apollo-client/issues/231) [PR #232](https://github.com/apollostack/apollo-client/pull/232) ### v0.3.9 From 66be245fb6fdb8869ed0d9075999cf290b0bbe72 Mon Sep 17 00:00:00 2001 From: Sashko Stubailo Date: Mon, 23 May 2016 10:30:55 -0700 Subject: [PATCH 3/4] Drop in new heading --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e36f5ac07a6..b21822628ec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ Expect active development and potentially significant breaking changes in the `0 ### vNEXT +### v0.3.10 + - Resolve a race condition between `QueryManager` `stopQuery()` and `broadcastQueries()`, which would result in an error `listener is not a function`. [Issue #231](https://github.com/apollostack/apollo-client/issues/231) [PR #232](https://github.com/apollostack/apollo-client/pull/232) ### v0.3.9 From bf1e05473e2d8b3ae92c3e91c4c8b82cb3c2c200 Mon Sep 17 00:00:00 2001 From: Sashko Stubailo Date: Mon, 23 May 2016 10:31:19 -0700 Subject: [PATCH 4/4] 0.3.10 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 0a630b3605e..09a76551d86 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "apollo-client", - "version": "0.3.9", + "version": "0.3.10", "description": "A simple yet functional GraphQL client.", "main": "./lib/src/index.js", "typings": "./lib/src/index.d.ts",