useFragment, returns false data.

[panchaldeep009]

Issue Description

There is a re-render instance where the useFragment returns the wrong data for the requested cache id.

Screen.Recording.2024-03-15.at.1.20.37.PM.mov

It is only for 1 or 2 render cycles, eventually, it re-renders and returns correct data. but the expected behavior should never return the wrong data for a cache ID.

Link to Reproduction

https://stackblitz.com/edit/vitejs-vite-po6ehx?file=src%2FApp.tsx

Reproduction Steps

• Open sandbox https://stackblitz.com/edit/vitejs-vite-po6ehx?file=src%2FApp.tsx
• Click on Load User 1
• Then Click on Load User 2

useFragment returns User 1 data for User 2 cache ID therefore based on code setup it will throw an exception that User id does not match Expected: 2, Actual: 1

@apollo/client version

3.9.7

[jerelmiller]

Hey @panchaldeep009 👋

I have a good idea on what might be happening here. Just to confirm, are you seeing another render after props change with the correct data? My guess is you're seeing this timeline:

render id: 1 -> render User:1
change props to id: 2 -> render User:1
render User:2

When you should be seeing this timeline:

render id: 1 -> render User:1
change props to id: 2 -> render User:2

I think we might have a gap in our tests unfortunately that didn't catch this earlier. Thanks for reporting!

[panchaldeep009]

Hey @panchaldeep009 👋

I have a good idea on what might be happening here. Just to confirm, are you seeing another render after props change with the correct data? My guess is you're seeing this timeline:

render id: 1 -> render User:1
change props to id: 2 -> render User:1
render User:2

When you should be seeing this timeline:

render id: 1 -> render User:1
change props to id: 2 -> render User:2

I think we might have a gap in our tests unfortunately that didn't catch this earlier. Thanks for reporting!

Yes, I was able to see the correct data on the next render cycle.

[jerelmiller]

Awesome thank you! I'll try and get to this as soon as I can.

[jerelmiller]

I've got a PR open to fix this: #11689. I would expect this to go out sometime next week. Thanks again for raising the issue!

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.