Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing fragmentMatcher to diffQueryAgainstStore options #1527

Merged
merged 1 commit into from
Apr 1, 2017

Conversation

msimulcik
Copy link
Contributor

Fixes #1526

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@helfer
Copy link
Contributor

helfer commented Mar 31, 2017

Thanks @msimulcik ! Could you add some tests to make sure the code actually works and we don't regress?

@msimulcik
Copy link
Contributor Author

Sure. Would it be enough to cover only the case when I call mutation and expect updateQueries and reducer on query with union type to be called? I'm thinking about adding it to test/client.ts

@helfer
Copy link
Contributor

helfer commented Mar 31, 2017

@msimulcik yes, I think that would be enough for now. I can add any other test cases if necessary 🙂

@helfer
Copy link
Contributor

helfer commented Apr 1, 2017

@msimulcik Actually, let me merge this and release a patch version. Would be great if you could add the test in a separate PR though.

@helfer helfer merged commit d685740 into apollographql:master Apr 1, 2017
@msimulcik
Copy link
Contributor Author

I'm on it now. I had to go to sleep yesterday :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants