You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unfortunately since that times several errors were introduced that makes the project not compatible with strictNullChecks anymore.
I am willing to attempt to create a PR to restore strictNullChecks, but first I need to be sure that it would get merged, since it seems to be a rather significant work.
Is there any interest to merge something like that ?
How to reproduce the issue:
Add "strictNullChecks": true, in tsconfig.json, and then run npm run build.
Intended outcome:
In preparation to create a PR to solve #5662, I would like to compile apollo-client with
strictNullChecks
enabled intsconfig.json
.Actual outcome:
npm run build
will fail with the messageFound 91 errors.
. All errors are of course related tostrictNullChecks
.strictNullChecks
was originally introduced in 2017 via #1221, but it seems it has been unintentionally removed in 2018 via 53230f4#diff-3daa69c0bea047c36f52994f7e96f2b2L8.Unfortunately since that times several errors were introduced that makes the project not compatible with
strictNullChecks
anymore.I am willing to attempt to create a PR to restore
strictNullChecks
, but first I need to be sure that it would get merged, since it seems to be a rather significant work.Is there any interest to merge something like that ?
How to reproduce the issue:
Add
"strictNullChecks": true,
intsconfig.json
, and then runnpm run build
.Versions
On latest master: f3c149c.
The text was updated successfully, but these errors were encountered: