Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-client is not compatible with strictNullChecks #6073

Closed
PowerKiKi opened this issue Mar 23, 2020 · 1 comment
Closed

apollo-client is not compatible with strictNullChecks #6073

PowerKiKi opened this issue Mar 23, 2020 · 1 comment

Comments

@PowerKiKi
Copy link
Contributor

Intended outcome:

In preparation to create a PR to solve #5662, I would like to compile apollo-client with strictNullChecks enabled in tsconfig.json.

Actual outcome:

npm run build will fail with the message Found 91 errors.. All errors are of course related to strictNullChecks.

strictNullChecks was originally introduced in 2017 via #1221, but it seems it has been unintentionally removed in 2018 via 53230f4#diff-3daa69c0bea047c36f52994f7e96f2b2L8.

Unfortunately since that times several errors were introduced that makes the project not compatible with strictNullChecks anymore.

I am willing to attempt to create a PR to restore strictNullChecks, but first I need to be sure that it would get merged, since it seems to be a rather significant work.

Is there any interest to merge something like that ?

How to reproduce the issue:

Add "strictNullChecks": true, in tsconfig.json, and then run npm run build.

Versions

On latest master: f3c149c.

  System:
    OS: Linux 4.15 Ubuntu 18.04.4 LTS (Bionic Beaver)
  Binaries:
    Node: 12.16.1 - /usr/bin/node
    Yarn: 1.22.4 - /usr/bin/yarn
    npm: 6.13.4 - /usr/bin/npm
  Browsers:
    Chrome: 80.0.3987.149
    Firefox: 74.0
@PowerKiKi
Copy link
Contributor Author

Fixed in #6080

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant