-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLSessionClient doesn't use custom URLSessionConfiguration #1230
Comments
That's...very weird. Here's the only place the session is set up, and you can see we're passing the session configuration in directly from the parameter, which it looks like you're passing in appropriately. What happens if you throw in a breakpoint after you set up |
Yeah if those are there, I've got absolutely zero idea why they wouldn't be getting sent with the request. At what point are you seeing them not being sent with the request, after it hits the wire? Or are you getting an error indicating they're not there? |
Never mind... Everything works as expected. Sorry for the missleading bug report. |
No worries, I'm just glad it actually works! 😃 |
We met in last years SwiftAlps and I really admire your work that you're doing here, Ellen! I'm trying to dig deep now in to GraphQL with Apollo and I hope I'll be able to contribute in the future. Take care! |
You too! |
After 0.27.0 changes for HTPPNetworkTransport init to use URLSessionClient instead of URLSession, custom URLSessionConfiguration properties such as htppAdditionalHeaders don't get configured.
Previously using the same URLSessionConfiguration, the HTPPNetworkTransport class got the URLSessionClient configured accordingly and requests were sent correctly.
The text was updated successfully, but these errors were encountered: