Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about standard extensions but also make it Just Work™ with any extension #2060

Open
calvincestari opened this issue Dec 9, 2021 · 0 comments
Labels
codegen Issues related to or arising from code generation v1.x

Comments

@calvincestari
Copy link
Member

calvincestari commented Dec 9, 2021

See #2059.

The part about "make it Just Work™ with any extension" is that ApolloCodegenConfiguration has separate FileInput properties for schema and operations. These could conceivably have any extension since the content is loaded and fed into the JS frontend. For that to work though ApolloCodegen.compileResults(using:) would need to change to use loadSchemaFromSDL or loadSchemaFromIntrospectionResult instead of loadSchema which looks at the extension for a hint on how to handle the file.

@calvincestari calvincestari added the codegen Issues related to or arising from code generation label Dec 9, 2021
@calvincestari calvincestari added this to the Release 1.0 milestone Dec 9, 2021
@calvincestari calvincestari changed the title Add note about standard extensions but also make it Just Work™ with any extension for focused inputs Add note about standard extensions but also make it Just Work™ with any extension Dec 10, 2021
@hwillson hwillson modified the milestone: Release 1.0 Dec 13, 2021
@calvincestari calvincestari removed this from the Release 1.0 (Alpha) milestone May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen Issues related to or arising from code generation v1.x
Projects
None yet
Development

No branches or pull requests

2 participants