-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't load apollo-upload-server if uploads are disabled #1536
Comments
I believe https://github.com/jaydenseric/apollo-upload-server/releases/tag/v6.0.0-alpha.1 would fix the issue but it's still in alpha. |
@Akryum It does seem wise to avoid loading Should we keep this open? (I think a PR that conditionally |
I actually already did this as part of a PR for running Apollo Server on edge. I'll pick that work up later, but I've just merged those commits to get this in and avoid the PR from getting out of sync. |
If
uploads
option is false onApolloServer
constructor options, theapollo-upload-server
module is still loaded. On some node versions, this causes issues likecore-js
not being found.This would help close vuejs/vue-cli#2215 (we don't need file uploads for vue cli ui).
The text was updated successfully, but these errors were encountered: